new rule: no-side-effects-wait-for

[renatoagds]

Following the proposed for Kent at his post (https://kentcdodds.com/blog/common-mistakes-with-react-testing-library). I would like to suggest a new rule that detects side effects inside a wait-for:

❌ // wrong
await waitFor(() => {
  fireEvent.click(a)
  expect(b).toEqual('b')
})

✅ // correct
fireEvent.click(a)
await waitFor(() => expect(b).toEqual('b'))

[Belco90]

Sorry, I closed this one by mistake! Thanks again Renato, this suggestion sounds good too.

We would have to identify which side effects we want to check here, I guess those from testing library itself.

Again, would like to give it a try? PRs are welcome!

[renatoagds]

We would have to identify which side effects we want to check here, I guess those from testing library itself.

@Belco90 Yes! I was think to add fireEvent and userEvent initially. Sounds good?

[Belco90]

Sounds good!

[renatoagds]

Just to update! I'm finishing #133 this week and will start work on this one 🚀

[Belco90]

Awesome, thanks for your help 💪

[github-actions]

🎉 This issue has been resolved in version 4.0.0-beta.1 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀