Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way to specify a folder for scripts #8

Closed
eisisig opened this issue Apr 11, 2016 · 7 comments
Closed

Way to specify a folder for scripts #8

eisisig opened this issue Apr 11, 2016 · 7 comments

Comments

@eisisig
Copy link

eisisig commented Apr 11, 2016

I'm intrigued! But for me to be able to use it I would have to specify another folder name and/or path where scripty would look for scripts. Would that make sense?

./scripts/* => ./core/scripts/* etc... I don't want to add another namespace infront of the scripts names core:dev:app

@searls
Copy link
Member

searls commented Apr 12, 2016

👍 this sounds good to me. I think we should probably implement this with a scripty entry in the package.json file.

"scripty": {
  "scriptsDir": "core"
}

Scripty, in turn, will search that directory instead of "scripts". Sound good?

@searls
Copy link
Member

searls commented Apr 12, 2016

Note: We'll probably also need a configuration option for windows scripts, as well

@eisisig
Copy link
Author

eisisig commented Apr 12, 2016

Thats sounds like the way to go. We have a few "custom" configs in our pacakge.json (babel, ava etc...)

@searls
Copy link
Member

searls commented Apr 12, 2016

Yeah, that seems to be the way things are going, and seems doubly appropriate when the cli is coupled npm to begin with.

@gvn
Copy link

gvn commented Apr 15, 2016

Naming-things suggestion: path instead of scriptsDir

Maybe a little less semantic, but more concise? ¯\_(ツ)_/¯

@searls
Copy link
Member

searls commented Apr 16, 2016

@gvn -- whatever I pick I'll try to be careful about it. As mentioned above, we're only talking about scripts in the user directory, but we'll need a way to specify either/or of scripts and scripts-win, so path is probably too generic. I also want to be careful of introducing too generic of an option name as I start to noodle on the potential needs of a future plugin module system.

@searls
Copy link
Member

searls commented Apr 17, 2016

FYI, I went with path and windowsPath after lots of test rewriting of the internal names.

Landed in 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants