Correct order of stubbing to allow iam_creds to work in test suite

Author: James Awesome

spec/create_spec.rb

@@ -49,14 +49,13 @@
       }
     end
 
+  context 'Interface is set in config' do
     before do
       instance
       allow(driver).to receive(:create_server).and_return(server)
       allow(driver).to receive(:wait_for_sshd)
     end
 
-  context 'Interface is set in config' do
-
     it 'derives hostname from DNS when specified in the .kitchen.yml' do
       config[:interface] = 'dns'
       driver.create(state)
@@ -83,6 +82,11 @@
   end
 
   context 'Interface is derived automatically' do
+    before do
+      instance
+      allow(driver).to receive(:create_server).and_return(server)
+      allow(driver).to receive(:wait_for_sshd)
+    end
 
     let(:server) do
       double(:id => "123",
@@ -122,6 +126,11 @@
   end
 
   context 'user_data implementation is working' do
+    before do
+      instance
+      allow(driver).to receive(:create_server).and_return(server)
+      allow(driver).to receive(:wait_for_sshd)
+    end
 
     it 'user_data is not defined' do
       driver.create(state)
@@ -137,16 +146,28 @@
   end
 
   context 'When #iam_creds returns values' do
-    context 'but they should not be used' do
-      before do
-        allow(ENV).to receive(:[]).and_return(nil)
-        allow(driver).to receive(:iam_creds).and_return(iam_creds)
-        allow(Net::HTTP).to receive(:get).with(URI.parse('http://169.254.169.254')).and_return(true)
-      end
+    let(:config) do
+      {
+        aws_ssh_key_id: 'larry',
+        user_data: nil
+      }
+    end
+
+    before do
+      allow(ENV).to receive(:[]).and_return(nil)
+      allow(driver).to receive(:iam_creds).and_return(iam_creds)
+      instance
+    end
 
+    context 'but they should not be used' do
       context 'because :aws_access_key_id is set but not via #iam_creds' do
+        let(:aws_access_key_id) { 'secret' }
+        before do
+          config[:aws_access_key_id] = aws_access_key_id
+        end
+
         it 'does not override :aws_access_key_id' do
-          expect(driver.send(:config)[:aws_access_key_id]).to eq(config[:aws_access_key_id])
+          expect(driver.send(:config)[:aws_access_key_id]).to eq(aws_access_key_id)
         end
 
         it 'does not set :aws_session_token via #iam_creds' do
@@ -155,9 +176,15 @@
         end
       end
 
-      context 'because :aws_access_key_id is set but not via #iam_creds' do
+      context 'because :aws_secret_access_key is set but not via #iam_creds' do
+        let(:aws_secret_access_key) { 'moarsecret' }
+
+        before do
+          config[:aws_secret_access_key] = aws_secret_access_key
+        end
+
         it 'does not override :aws_secret_access_key' do
-          expect(driver.send(:config)[:aws_secret_access_key]).to eq(config[:aws_secret_access_key])
+          expect(driver.send(:config)[:aws_secret_access_key]).to eq(aws_secret_access_key)
         end
 
         it 'does not set :aws_session_token via #iam_creds' do
@@ -167,7 +194,10 @@
       end
 
       context 'because :aws_session_token is set but not via #iam_creds' do
-        before { config[:aws_session_token] = 'adifferentsessiontoken' }
+        let(:aws_session_token) { 'adifferentsessiontoken' }
+        before do
+          config[:aws_session_token] = aws_session_token
+        end
         it 'does not override :aws_session_token' do
           expect(driver.send(:config)[:aws_session_token]).to eq('adifferentsessiontoken')
         end
@@ -182,11 +212,6 @@
         }
       end
 
-      before do
-        allow(ENV).to receive(:[]).and_return(nil)
-        allow(driver).to receive(:iam_creds).and_return(iam_creds)
-      end
-
       it 'uses :aws_access_key_id from iam_creds' do
         expect(driver.send(:config)[:aws_access_key_id]).to eq(iam_creds[:aws_access_key_id])
       end
@@ -204,40 +229,44 @@
   describe '#iam_creds' do
     context 'when a metadata service is available' do
       before do
-        allow(Net::HTTP).to receive(:get).with(URI.parse('http://169.254.169.254')).and_return(true)
+        allow(Net::HTTP).to receive(:get).and_return(true)
       end
 
       context 'and #fetch_credentials returns valid iam credentials' do
         it '#iam_creds retuns the iam credentials from fetch_credentials' do
           allow(driver).to receive(:fetch_credentials).and_return(iam_creds)
-          expect(driver.send(:iam_creds)).to eq(iam_creds)
+          expect(driver.iam_creds).to eq(iam_creds)
         end
       end
 
       context 'when #fetch_credentials fails with NoMethodError' do
         it 'returns an empty hash' do
           allow(driver).to receive(:fetch_credentials).and_raise(NoMethodError)
+          expect { driver.fetch_credentials }.to raise_error(NoMethodError)
           expect(driver.iam_creds).to eq({})
         end
       end
 
       context 'when #fetch_credentials fails with ::StandardError' do
         it 'returns an empty hash' do
           allow(driver).to receive(:fetch_credentials).and_raise(::StandardError)
+          expect { driver.fetch_credentials }.to raise_error(::StandardError)
           expect(driver.iam_creds).to eq({})
         end
       end
 
       context 'when #fetch_credentials fails with Errno::EHOSTUNREACH' do
         it 'returns an empty hash' do
           allow(driver).to receive(:fetch_credentials).and_raise(Errno::EHOSTUNREACH)
+          expect { driver.fetch_credentials }.to raise_error(Errno::EHOSTUNREACH)
           expect(driver.iam_creds).to eq({})
         end
       end
 
       context 'when #fetch_credentials fails with Timeout::Error' do
         it 'returns an empty hash' do
           allow(driver).to receive(:fetch_credentials).and_raise(Timeout::Error)
+          expect { driver.fetch_credentials }.to raise_error(Timeout::Error)
           expect(driver.iam_creds).to eq({})
         end
       end
@@ -253,6 +282,11 @@
   end
 
   describe '#block_device_mappings' do
+    before do
+      instance
+      allow(driver).to receive(:create_server).and_return(server)
+      allow(driver).to receive(:wait_for_sshd)
+    end
     let(:connection) { double(Fog::Compute) }
     let(:image) { double('Image', :root_device_name => 'name') }
     before do