-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microsoft Teams destination to notification_configuration #484
Conversation
96d57f0
to
af9a31e
Compare
f8eb9e7
to
1ef4e23
Compare
a97a821
to
f69c4c9
Compare
go.mod
Outdated
@@ -13,7 +13,7 @@ require ( | |||
github.com/hashicorp/go-multierror v1.1.1 // indirect | |||
github.com/hashicorp/go-retryablehttp v0.7.1 // indirect | |||
github.com/hashicorp/go-slug v0.8.1 | |||
github.com/hashicorp/go-tfe v1.2.0 | |||
github.com/hashicorp/go-tfe v1.2.1-0.20220607193402-515f37b540ef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be updated or is this version tag correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is what was holding this up! I was waiting on the 1.3.0 release
This is looking good to me aside from the question about the go-tfe version |
f69c4c9
to
44f53ab
Compare
Description
Adds
microsoft_teams
as a valid destination for anotification_configuration
The Microsoft Teams notification config will be the same as the Slack notification config, so this is mostly a copy of the Slack notification implementation and tests
Blocked on:
Testing plan
tfe
provider can create, update, and destroy notification configurations for MS TeamsExternal links
Output from acceptance tests