Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secondary range support to google_compute_subnetwork data source #687

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

negz
Copy link
Contributor

@negz negz commented Nov 6, 2017

..and throw in project and region while we're at it, which should fix #159.

$ GOOGLE_XPN_HOST_PROJECT=REDACTED \
  GOOGLE_PROJECT=REDACTED \
  GOOGLE_REGION=us-central1 \
  GOOGLE_USE_DEFAULT_CREDENTIALS=1 \
  TF_ACC=1 \
  go test -v . -run "^TestAccDataSourceGoogleSubnetwork$"                                                                
=== RUN   TestAccDataSourceGoogleSubnetwork                                                                          
--- PASS: TestAccDataSourceGoogleSubnetwork (313.85s)                               
PASS                                                                   
ok      github.com/terraform-providers/terraform-provider-google/google 313.872s

..and throw in project and region while we're at it.
@rosbo rosbo self-requested a review November 6, 2017 18:59
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nic! Merging

TF_ACC=1 go test ./google -v -run TestAccDataSourceGoogleSubnetwork -timeout 120m
=== RUN   TestAccDataSourceGoogleSubnetwork
--- PASS: TestAccDataSourceGoogleSubnetwork (389.84s)
PASS

@rosbo rosbo merged commit 96db217 into hashicorp:master Nov 6, 2017
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_subnetwork missing project & region attributes
2 participants