Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when creating node pools with name_prefix or no name #531

Merged
merged 1 commit into from
Oct 4, 2017

Conversation

danawillow
Copy link
Contributor

Fixes #479.

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerNodePool_noName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerNodePool_noName -timeout 120m
=== RUN   TestAccContainerNodePool_noName
--- PASS: TestAccContainerNodePool_noName (573.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	574.179s
$ make testacc TEST=./google TESTARGS='-run=TestAccContainerNodePool_namePrefix'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerNodePool_namePrefix -timeout 120m
=== RUN   TestAccContainerNodePool_namePrefix
--- PASS: TestAccContainerNodePool_namePrefix (614.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	615.102s
$ make testacc TEST=./google TESTARGS='-run=TestAccContainerCluster_withNodePoolNamePrefix'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_withNodePoolNamePrefix -timeout 120m
=== RUN   TestAccContainerCluster_withNodePoolNamePrefix
--- PASS: TestAccContainerCluster_withNodePoolNamePrefix (387.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	387.860s

@danawillow danawillow requested a review from rosbo October 4, 2017 23:13
@danawillow danawillow merged commit 5b3bd34 into hashicorp:master Oct 4, 2017
@danawillow danawillow deleted the is-479 branch October 4, 2017 23:41
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash adding new google_container_node_pool to google_container_cluster
2 participants