Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new data source: google_dns_managed_zone #268

Merged
merged 3 commits into from
Jul 31, 2017
Merged

Add new data source: google_dns_managed_zone #268

merged 3 commits into from
Jul 31, 2017

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Jul 28, 2017

@rosbo rosbo requested a review from danawillow July 28, 2017 23:58
danawillow
danawillow reviewed Jul 29, 2017
View reviewed changes
google/data_source_dns_managed_zone_test.go Outdated

rs, ok := s.RootModule().Resources[rsFullName]
if !ok {
return fmt.Errorf("can't find %s in state", rsFullName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to have different wording for the two error messages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that I copied and pasted this snippet from another test. No ;)

Fixed

danawillow
danawillow reviewed Jul 29, 2017
View reviewed changes
website/docs/d/dns_managed_zone.html.markdown Outdated
[the official documentation](https://cloud.google.com/dns/zones/)
and
[API](https://cloud.google.com/dns/api/v1/managedZones).
```
Copy link
Contributor

@danawillow danawillow Jul 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be ```tf or ```hcl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

danawillow
danawillow reviewed Jul 29, 2017
View reviewed changes
website/docs/d/dns_managed_zone.html.markdown Outdated

## Argument Reference

* `name` - (Required) A unique name for the resource, required by GCE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCE isn't relevant here, is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oupps. I meant to clean up these descriptions before opening the PR... Forgot about it ;)

danawillow
danawillow reviewed Jul 29, 2017
View reviewed changes
website/docs/d/dns_managed_zone.html.markdown Outdated
## Argument Reference

* `name` - (Required) A unique name for the resource, required by GCE.
Changing this forces a new resource to be created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for a data source

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

danawillow
danawillow reviewed Jul 29, 2017
View reviewed changes
website/docs/d/dns_managed_zone.html.markdown Outdated
* `name` - (Required) A unique name for the resource, required by GCE.
Changing this forces a new resource to be created.

* `project` (optional) - ID of the project to list available cluster versions for. Should match the project the cluster will be deployed to.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it needs to be updated from what this page was copied from

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

danawillow
danawillow reviewed Jul 29, 2017
View reviewed changes
website/docs/d/dns_managed_zone.html.markdown Outdated

* `dns_name` - The DNS name of this zone, e.g. "terraform.io".

* `description` - A textual description field. Defaults to 'Managed by Terraform'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults aren't really relevant for data sources

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@danawillow
Copy link
Contributor 

make testacc TEST=./google TESTARGS='-run=TestAccDataSourceDnsManagedZone'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccDataSourceDnsManagedZone -timeout 120m
=== RUN   TestAccDataSourceDnsManagedZone_basic
--- PASS: TestAccDataSourceDnsManagedZone_basic (3.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	3.516s

LGTM, merge at will

@rosbo rosbo merged commit 53e4814 into hashicorp:master Jul 31, 2017
@johnsonj
Copy link
Contributor

johnsonj commented Jul 31, 2017 via email

z1nkum pushed a commit to z1nkum/terraform-provider-google that referenced this pull request Aug 15, 2017
@rosbo
Add new data source: google_dns_managed_zone (hashicorp#268)
020cd8a
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
@rosbo
Add new data source: google_dns_managed_zone (hashicorp#268)
bc20268
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@rosbo
Add new data source: google_dns_managed_zone (hashicorp#268)
13f8471
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@modular-magician @rileykarson
Add support for private DNS Managed Zones (hashicorp#268)
936be2a 
<!-- This change is generated by MagicModules. -->
/cc @drebes
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
flozzone pushed a commit to flozzone/terraform-provider-google that referenced this pull request Oct 17, 2024
@kopachevsky
Add submodule to set up ACM
e3a05d8 
Added standalone ACM submodule, embedded acm to examples/simple_zonal.

Fixes hashicorp#268
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danawillow danawillow danawillow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support google_dns_managed_zone as a data source
3 participants
@rosbo @danawillow @johnsonj