Add support for data source 'google_iam_role' #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileykarson
requested changes
Nov 16, 2018
There was a problem hiding this comment.
Thanks for the contribution @manuelfelipe! I just have a few minor comments.
|
hey @rileykarson, pushed the changes. ready for a second review |
rileykarson
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
Thanks for the contribution, looks good to me! I'll mirror these changes into Magic Modules and merge this PR alongside the MM upstream.
nat-henderson
pushed a commit
that referenced
this pull request
Dec 4, 2018
Add `google_iam_role` data source to be able to fetch and query for GCP IAM roles permissions.
nat-henderson
pushed a commit
that referenced
this pull request
Dec 5, 2018
Add `google_iam_role` data source to be able to fetch and query for GCP IAM roles permissions.
nat-henderson
pushed a commit
that referenced
this pull request
Dec 6, 2018
Add `google_iam_role` data source to be able to fetch and query for GCP IAM roles permissions.
nat-henderson
pushed a commit
that referenced
this pull request
Dec 13, 2018
Add `google_iam_role` data source to be able to fetch and query for GCP IAM roles permissions.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
google_iam_roledata source to be able to fetch and query for GCP IAM roles permissions.