Dataproc autogen bucket changes #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danawillow
changed the title
danawillow
changed the title
paddycarver
suggested changes
Mar 12, 2018
google/resource_dataproc_cluster.go
Outdated
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| Default: false, | ||
| Deprecated: "see documentation", |
There was a problem hiding this comment.
A link to the documentation here would be great.
|
Added more context to the deprecation message. |
paddycarver
approved these changes
Mar 13, 2018
ashish-amarnath
pushed a commit
to ashish-amarnath/terraform-provider-google
that referenced
this pull request
Mar 20, 2018
* add extra wait for storage bucket object deletion * make timeout for object deletion 5 minutes, make it succeed 3 times * delete the cluster before deleting the bucket * deprecate delete_autogen_bucket * improve deprecation message
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
* add extra wait for storage bucket object deletion * make timeout for object deletion 5 minutes, make it succeed 3 times * delete the cluster before deleting the bucket * deprecate delete_autogen_bucket * improve deprecation message
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
delete_autogen_bucket. This shouldn't really be an option- clusters in the same region all share the same autogenerated bucket, so if we delete it then it's unclear what would happen to other dataproc clusters in that region. There's not really much harm in keeping it around, since there's only one per region.