Include iap in appengine patch updatemask. #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <[email protected]>
ghost
added
the
modular-magician
deleted the
downstream-pr-7ceaf320f39c6f85a3a42993b44d2596bb7d39a6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
Now that 3.18 is out, I noticed that no changes to the
iapblock have any effect on update because we don't include "iap" in the patch update mask. This patch adds "iap" to the update mask. I can also put a little more time into this and build the update mask based on the attributes that have changed, but we're already hard-coding the mask, so I haven't changed it so far.@chrisst @danawillow
Derived from GoogleCloudPlatform/magic-modules#3418