Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LB target group maximum timeout #9152

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Update LB target group maximum timeout #9152

merged 1 commit into from
Jun 27, 2019

Conversation

rwolfson
Copy link
Contributor

The current AWS documentation indicates the maximum health check timeout
should be 120 seconds; Terraform currently limits the range to 60 seconds. The AWS web console also shows a range up to 120 seconds.

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/target-group-health-checks.html

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Update LB target group timeout range

Output from acceptance testing:

N/A / Not tested

The current documentation indicates the maximum health check timeout
should be 120 seconds.

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/target-group-health-checks.html
@rwolfson rwolfson requested a review from a team June 26, 2019 19:13
@ghost ghost added service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Jun 26, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Jun 27, 2019
@bflad bflad added this to the v2.17.0 milestone Jun 27, 2019
@bflad bflad self-assigned this Jun 27, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this fix and for the documentation link, @rwolfson 🚀

--- PASS: TestAccAWSLBTargetGroup_basic (21.51s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (22.59s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (25.29s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (29.66s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (31.93s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (32.47s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (33.22s)
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPEnabledShouldError (2.85s)
--- PASS: TestAccAWSLBTargetGroupBackwardsCompatibility (34.93s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (35.16s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (36.70s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (38.43s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (41.67s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (18.93s)
--- PASS: TestAccAWSLBTargetGroup_tags (42.10s)
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPDisabled (13.39s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (46.43s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (46.81s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (24.60s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (49.94s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (69.11s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (49.46s)
--- PASS: TestAccAWSLBTargetGroupAttachment_basic (80.19s)
--- PASS: TestAccAWSLBTargetGroupAttachmentBackwardsCompatibility (85.82s)

@bflad bflad merged commit a169a81 into hashicorp:master Jun 27, 2019
bflad added a commit that referenced this pull request Jun 27, 2019
@bflad
Copy link
Contributor

bflad commented Jun 28, 2019

This has been released in version 2.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants