Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add update step for change tags for aws_backup_vault resource #7933

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Add update step for change tags for aws_backup_vault resource #7933

merged 2 commits into from
Mar 15, 2019

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7801

Changes proposed in this pull request:

  • Add step for update tags

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupVault_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsBackupVault_ -timeout 120m
=== RUN   TestAccAwsBackupVault_basic
=== PAUSE TestAccAwsBackupVault_basic
=== RUN   TestAccAwsBackupVault_withKmsKey
=== PAUSE TestAccAwsBackupVault_withKmsKey
=== RUN   TestAccAwsBackupVault_withTags
=== PAUSE TestAccAwsBackupVault_withTags
=== CONT  TestAccAwsBackupVault_basic
=== CONT  TestAccAwsBackupVault_withTags
=== CONT  TestAccAwsBackupVault_withKmsKey
--- PASS: TestAccAwsBackupVault_basic (31.67s)
--- PASS: TestAccAwsBackupVault_withTags (52.90s)
--- PASS: TestAccAwsBackupVault_withKmsKey (65.63s)
PASS
ok  	github.com/terraform-providers/tmp-terraform-provider-aws/aws	65.699s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 14, 2019
@slapula
Copy link
Contributor

slapula commented Mar 14, 2019

LGTM

slapula
slapula reviewed Mar 14, 2019
View reviewed changes
aws/resource_aws_backup_vault_test.go
resource.TestCheckResourceAttr("aws_backup_vault.test", "tags.foo", "bar"),
resource.TestCheckResourceAttr("aws_backup_vault.test", "tags.fizz", "buzz"),
),
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to test adding/removing tags too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added test case.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupVault_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsBackupVault_ -timeout 120m
=== RUN   TestAccAwsBackupVault_basic
=== PAUSE TestAccAwsBackupVault_basic
=== RUN   TestAccAwsBackupVault_withKmsKey
=== PAUSE TestAccAwsBackupVault_withKmsKey
=== RUN   TestAccAwsBackupVault_withTags
=== PAUSE TestAccAwsBackupVault_withTags
=== CONT  TestAccAwsBackupVault_basic
=== CONT  TestAccAwsBackupVault_withTags
=== CONT  TestAccAwsBackupVault_withKmsKey
--- PASS: TestAccAwsBackupVault_basic (33.29s)
--- PASS: TestAccAwsBackupVault_withKmsKey (66.19s)
--- PASS: TestAccAwsBackupVault_withTags (74.41s)
PASS
ok  	github.com/terraform-providers/tmp-terraform-provider-aws/aws	74.504s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service. labels Mar 15, 2019
bflad
bflad approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509 and @slapula 🚀

--- PASS: TestAccAwsBackupVault_basic (6.48s)
--- PASS: TestAccAwsBackupVault_withTags (10.48s)
--- PASS: TestAccAwsBackupVault_withKmsKey (26.49s)

@bflad bflad added this to the v2.2.0 milestone Mar 15, 2019
@bflad bflad merged commit 0350a64 into hashicorp:master Mar 15, 2019
bflad added a commit that referenced this pull request Mar 15, 2019
@bflad
Update CHANGELOG for #7933
c6524f0
@bflad
Copy link
Contributor

bflad commented Mar 15, 2019

This has been released in version 2.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-update-step-for-backup-vault branch March 5, 2020 14:05
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slapula slapula slapula left review comments

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

aws_backup_vault forces new resource when updating tags
3 participants
@teraken0509 @slapula @bflad