Add aws codebuild source credential resource

[teraken0509]

Closes #7025
Closes #7435

Changes proposed in this pull request:

• Add aws_codebuild_source_credential resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildSourceCredential_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCodeBuildSourceCredential_ -timeout 120m
=== RUN   TestAccAWSCodeBuildSourceCredential_Basic
=== PAUSE TestAccAWSCodeBuildSourceCredential_Basic
=== RUN   TestAccAWSCodeBuildSourceCredential_BasicAuth
=== PAUSE TestAccAWSCodeBuildSourceCredential_BasicAuth
=== CONT  TestAccAWSCodeBuildSourceCredential_Basic
=== CONT  TestAccAWSCodeBuildSourceCredential_BasicAuth
--- PASS: TestAccAWSCodeBuildSourceCredential_Basic (49.43s)
--- PASS: TestAccAWSCodeBuildSourceCredential_BasicAuth (49.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	49.623s

[teraken0509]

Re-run acctest.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildSourceCredential_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCodeBuildSourceCredential_ -timeout 120m
=== RUN   TestAccAWSCodeBuildSourceCredential_Basic
=== PAUSE TestAccAWSCodeBuildSourceCredential_Basic
=== RUN   TestAccAWSCodeBuildSourceCredential_BasicAuth
=== PAUSE TestAccAWSCodeBuildSourceCredential_BasicAuth
=== CONT  TestAccAWSCodeBuildSourceCredential_Basic
=== CONT  TestAccAWSCodeBuildSourceCredential_BasicAuth
--- PASS: TestAccAWSCodeBuildSourceCredential_Basic (53.06s)
--- PASS: TestAccAWSCodeBuildSourceCredential_BasicAuth (53.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.212s

[bflad]

Hi @kterada0509 👋 Thanks for submitting this. Just a few things and this should be good to go. Please reach out if you have any questions or do not have time to implement the feedback.

[bflad]

Can you please implement resource import support? More information on the required steps can be found in the Contributing Guide. This resource testing will likely require ImportStateVerifyIgnore: []string{"token", "user_name"} Thanks!

Suggested change

	Importer: &schema.ResourceImporter{
	State: schema.ImportStatePassthrough,
	},

[teraken0509]

fixed in c13110c

[bflad]

d.GetOk() automatically checks for zero values so the empty string check is extraneous 👍

Suggested change

	if attr, ok := d.GetOk("user_name"); ok && attr.(string) != "" && authType == codebuild.AuthTypeBasicAuth {
	if attr, ok := d.GetOk("user_name"); ok && authType == codebuild.AuthTypeBasicAuth {

[teraken0509]

fixed in 64959a1

[bflad]

Preferably the Create function should return the Read function and this d.Set() should be handled in there. 👍

Suggested change

d.Set("arn", resp.Arn)

[teraken0509]

fixed in de6da2b

[bflad]

Preferably the Create function should return the Read function.

Suggested change

	return nil
	return resourceAwsCodeBuildSourceCredentialRead(d, meta)

[teraken0509]

fixed in 05104d7

[bflad]

Typically we prefer to use relevant object type as the output variable when searching like this, which simplifies the logic and allows the code to read well on the left side:

var info *codebuild.SourceCredentialInfo

for _, sourceCredentialsInfo := range resp.SourceCredentialsInfos {
	if d.Id() == aws.StringValue(sourceCredentialsInfo.Arn) {
		info = sourceCredentialInfo
		break
	}
}

if info == nil {
	log.Printf("[WARN] CodeBuild Source Credential (%s) not found, removing from state", d.Id())
	d.SetId("")
	return nil
}

d.Set("arn", info.Arn)
d.Set("auth_type", info.AuthType)
d.Set("server_type", info.ServerType)

return nil

[teraken0509]

fixed in 588a1c3

[bflad]

Typo 😎

Suggested change

	if !isAWSErr(err, codebuild.ErrCodeResourceNotFoundException, "") {
	if isAWSErr(err, codebuild.ErrCodeResourceNotFoundException, "") {

[teraken0509]

fixed in 588a1c3

[bflad]

Copy pasta 🍝 and sitewide documentation update that occurred after this PR was submitted 👍

Suggested change

	# aws_codebuild_project
	# Resource: aws_codebuild_source_credential

[teraken0509]

fixed in a938f7a

[teraken0509]

Re-run acctest.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildSourceCredential_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCodeBuildSourceCredential_ -timeout 120m
=== RUN   TestAccAWSCodeBuildSourceCredential_Basic
=== PAUSE TestAccAWSCodeBuildSourceCredential_Basic
=== RUN   TestAccAWSCodeBuildSourceCredential_BasicAuth
=== PAUSE TestAccAWSCodeBuildSourceCredential_BasicAuth
=== CONT  TestAccAWSCodeBuildSourceCredential_Basic
=== CONT  TestAccAWSCodeBuildSourceCredential_BasicAuth
--- PASS: TestAccAWSCodeBuildSourceCredential_Basic (51.97s)
--- PASS: TestAccAWSCodeBuildSourceCredential_BasicAuth (52.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	52.268s

@bflad ready for re-review.

[bflad]

Looks good, @kterada0509, thanks! 🚀 Will add to sidebar on merge and thinking it might be a good idea to mark the token attribute as Sensitive: true as well. 😄

[ghost]

This has been released in version 2.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!