Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5470 aws_cloudwatch_metric_alarm should expsose arn #5487

Merged
merged 4 commits into from
Aug 9, 2018
Merged

Issue #5470 aws_cloudwatch_metric_alarm should expsose arn #5487

merged 4 commits into from
Aug 9, 2018

Conversation

saravanan30erd
Copy link
Contributor

Fixes #5470

Changes proposed in this pull request:

  • Change 1
    added arn attribute

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCloudWatchMetricAlarm_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSCloudWatchMetricAlarm_basic -timeout 120m
=== RUN   TestAccAWSCloudWatchMetricAlarm_basic
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (31.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	(cached)
...

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Aug 9, 2018
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Aug 9, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. labels Aug 9, 2018
bflad
bflad approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

7 tests passed (all tests)
=== RUN   TestAccAWSCloudWatchMetricAlarm_missingStatistic
--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (1.69s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_basic
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (3.66s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (3.85s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_extendedStatistic
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (3.91s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_importBasic
--- PASS: TestAccAWSCloudWatchMetricAlarm_importBasic (4.05s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_treatMissingData
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (6.29s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (6.70s)

aws/resource_aws_cloudwatch_metric_alarm.go
@@ -30,6 +30,10 @@ func resourceAwsCloudWatchMetricAlarm() *schema.Resource {
Required: true,
ForceNew: true,
},
"arn": &schema.Schema{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the &schema.Schema here is extraneous since Go 1.7 as its defined by map[string]*schema.Schema above

@bflad bflad merged commit 7ebf306 into hashicorp:master Aug 9, 2018
@bflad bflad added this to the v1.32.0 milestone Aug 9, 2018
bflad added a commit that referenced this pull request Aug 9, 2018
@bflad
Update CHANGELOG for #5487
5963b1f
@bflad
Copy link
Contributor

bflad commented Aug 16, 2018

This has been released in version 1.32.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.

aws_cloudwatch_metric_alarm should expsose arn
2 participants
@saravanan30erd @bflad