Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4713 New Resource: neptune_event_subscription #5480

Merged
merged 12 commits into from
Aug 9, 2018

Conversation

saravanan30erd
Copy link
Contributor

refer #4713

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSNeptuneEventSubscription_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSNeptuneEventSubscription_basic -timeout 120m
=== RUN   TestAccAWSNeptuneEventSubscription_basic
--- PASS: TestAccAWSNeptuneEventSubscription_basic (961.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	961.589s
...

@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label Aug 8, 2018
@bflad bflad added new-resource Introduces a new resource. service/neptune Issues and PRs that pertain to the neptune service. labels Aug 8, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, @saravanan30erd, thanks! 🚀

4 tests passed (all tests)
=== RUN   TestAccAWSNeptuneEventSubscription_withPrefix
--- PASS: TestAccAWSNeptuneEventSubscription_withPrefix (657.07s)
=== RUN   TestAccAWSNeptuneEventSubscription_withSourceIds
--- PASS: TestAccAWSNeptuneEventSubscription_withSourceIds (659.98s)
=== RUN   TestAccAWSNeptuneEventSubscription_basic
--- PASS: TestAccAWSNeptuneEventSubscription_basic (981.00s)
=== RUN   TestAccAWSNeptuneEventSubscription_withCategories
--- PASS: TestAccAWSNeptuneEventSubscription_withCategories (981.00s)

@bflad bflad added this to the v1.31.0 milestone Aug 9, 2018
@bflad bflad merged commit b05d98a into hashicorp:master Aug 9, 2018
bflad added a commit that referenced this pull request Aug 9, 2018
@bflad
Copy link
Contributor

bflad commented Aug 9, 2018

This has been released in version 1.31.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/neptune Issues and PRs that pertain to the neptune service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants