Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/emr_cluster: Fix emr cluster keep job flow #5415

Merged
merged 4 commits into from
Aug 1, 2018

Conversation

mlsmaycon
Copy link
Contributor

Fixes #1929

As #2845 seems abandoned, I've merged commits from branch created by @atsushi-ishibashi and added one step to the test as recommended for the acceptance testing.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEMRCluster_keepJob'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSEMRCluster_keepJob -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]

=== RUN   TestAccAWSEMRCluster_keepJob
--- PASS: TestAccAWSEMRCluster_keepJob (497.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	497.200s

...

@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Aug 1, 2018
@mlsmaycon mlsmaycon changed the title Fix emr cluster keep job flow resource/emr_cluster: Fix emr cluster keep job flow Aug 1, 2018
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Aug 1, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/emr Issues and PRs that pertain to the emr service. labels Aug 1, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mlsmaycon! 🚀

15 tests passed (all tests)
=== RUN   TestAccAWSEMRCluster_keepJob
--- PASS: TestAccAWSEMRCluster_keepJob (443.51s)
=== RUN   TestAccAWSEMRCluster_Step_Multiple
--- PASS: TestAccAWSEMRCluster_Step_Multiple (467.87s)
=== RUN   TestAccAWSEMRCluster_instance_group
--- PASS: TestAccAWSEMRCluster_instance_group (485.03s)
=== RUN   TestAccAWSEMRCluster_security_config
--- PASS: TestAccAWSEMRCluster_security_config (489.69s)
=== RUN   TestAccAWSEMRCluster_Step_Basic
--- PASS: TestAccAWSEMRCluster_Step_Basic (512.46s)
=== RUN   TestAccAWSEMRCluster_basic
--- PASS: TestAccAWSEMRCluster_basic (518.97s)
=== RUN   TestAccAWSEMRCluster_custom_ami_id
--- PASS: TestAccAWSEMRCluster_custom_ami_id (543.33s)
=== RUN   TestAccAWSEMRCluster_additionalInfo
--- PASS: TestAccAWSEMRCluster_additionalInfo (544.56s)
=== RUN   TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (545.15s)
=== RUN   TestAccAWSEMRCluster_bootstrap_ordering
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (569.46s)
=== RUN   TestAccAWSEMRCluster_terminationProtected
--- PASS: TestAccAWSEMRCluster_terminationProtected (586.32s)
=== RUN   TestAccAWSEMRCluster_s3Logging
--- PASS: TestAccAWSEMRCluster_s3Logging (700.90s)
=== RUN   TestAccAWSEMRCluster_visibleToAllUsers
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (772.50s)
=== RUN   TestAccAWSEMRCluster_root_volume_size
--- PASS: TestAccAWSEMRCluster_root_volume_size (859.35s)
=== RUN   TestAccAWSEMRCluster_tags
--- PASS: TestAccAWSEMRCluster_tags (913.45s)

@bflad bflad added this to the v1.30.0 milestone Aug 1, 2018
@bflad bflad merged commit 3f9b699 into hashicorp:master Aug 1, 2018
bflad added a commit that referenced this pull request Aug 2, 2018
@mlsmaycon mlsmaycon deleted the fix-emr_cluster_keep_job_flow branch August 2, 2018 03:59
@bflad
Copy link
Contributor

bflad commented Aug 2, 2018

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/emr Issues and PRs that pertain to the emr service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EMR AutoTerminate Feature not available.
3 participants