aws_rds_cluster is not setting engine_version for aurora postgres #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
bug
bflad
approved these changes
Apr 10, 2018
There was a problem hiding this comment.
Hi @miromad 👋 Thanks very much for this contribution! You'll help close out a few issues.
I created a new acceptance test to verify the attribute behavior, which is in a commit after yours.
Before code change:
make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSCluster_EngineVersion'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRDSCluster_EngineVersion -timeout 120m
=== RUN TestAccAWSRDSCluster_EngineVersion
--- FAIL: TestAccAWSRDSCluster_EngineVersion (137.46s)
testing.go:518: Step 0 error: Check failed: Check 3/3 error: aws_rds_cluster.test: Attribute 'engine_version' expected "9.6.6", got "9.6.3"
FAIL
FAIL github.com/terraform-providers/terraform-provider-aws/aws 137.502s
make: *** [testacc] Error 1
After code change:
make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSCluster_EngineVersion'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRDSCluster_EngineVersion -timeout 120m
=== RUN TestAccAWSRDSCluster_EngineVersion
--- PASS: TestAccAWSRDSCluster_EngineVersion (119.94s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 119.983s
bflad
added a commit
that referenced
this pull request
Apr 10, 2018
|
This has been released in version 1.14.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aurora for postgres added support for postgres 9.6.6 version in addition to 9.6.3 (default).
Attempt to set version 9.6.6 revealed that engine_version parameter was not added to all code paths in original enhancement.