Check VPC array size #1882
Merged
Check VPC array size #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaTP
force-pushed
the
checkVPCSPresence
branch
from
b9b3377 to
3da6863
Compare
|
Thank you for the contribution. Your contribution is still included (and still credited to you), with the appropriate modifications. |
radeksimko
approved these changes
Oct 16, 2017
|
sounds perfect to me @radeksimko thanks a lot, sorry first contribution to this codebase ... |
|
if you prefer I can squash commits to have a cleaner tree |
|
ok wow, thanks! :-) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This missing check causes a terraform crash when used with Eucalyptus Cloud.
I know that supporting AWS clones is not a target for this project but the fix here just increase robustness of the implementation IMO.