Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SSM resources to use keyvaluetags #11290

Merged
merged 9 commits into from
Dec 18, 2019

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 14, 2019

add tags to read

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSSMActivation_'
--- PASS: TestAccAWSSSMActivation_basic (80.97s)
--- PASS: TestAccAWSSSMActivation_update (181.12s)
--- PASS: TestAccAWSSSMActivation_expirationDate (83.87s)
...
$ make testacc TESTARGS='-run=TestAccAWSSSMDocument_'
--- PASS: TestAccAWSSSMDocument_basic (82.10s)
--- PASS: TestAccAWSSSMDocument_update (82.58s)
--- PASS: TestAccAWSSSMDocument_permission_public (57.40s)
--- PASS: TestAccAWSSSMDocument_permission_private (75.18s)
--- PASS: TestAccAWSSSMDocument_permission_batching (56.50s)
--- PASS: TestAccAWSSSMDocument_permission_change (133.64s)
--- PASS: TestAccAWSSSMDocument_params (53.26s)
--- PASS: TestAccAWSSSMDocument_automation (81.57s)
--- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (88.65s)
--- PASS: TestAccAWSSSMDocument_session (55.26s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (120.44s)
--- PASS: TestAccAWSSSMDocument_Tags (129.50s)
...
$ make testacc TESTARGS='-run=TestAccAWSSSMParameter_'
--- PASS: TestAccAWSSSMParameter_basic (57.59s)
--- PASS: TestAccAWSSSMParameter_Tier (166.26s)
--- PASS: TestAccAWSSSMParameter_disappears (36.12s)
--- PASS: TestAccAWSSSMParameter_overwrite (95.30s)
--- PASS: TestAccAWSSSMParameter_tags (202.11s)
--- PASS: TestAccAWSSSMParameter_updateDescription (92.01s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (95.33s)
--- PASS: TestAccAWSSSMParameter_fullPath (58.37s)
--- PASS: TestAccAWSSSMParameter_secure (55.30s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (127.53s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (214.12s)
...
$ make testacc TESTARGS='-run=TestAccAWSSSMPatchBaseline_'
--- PASS: TestAccAWSSSMPatchBaseline_basic (102.99s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (213.51s)
--- PASS: TestAccAWSSSMPatchBaseline_disappears (38.27s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (108.80s)
...
$ make testacc TESTARGS='-run=TestAccAWSSSMMaintenanceWindow_'
--- PASS: TestAccAWSSSMMaintenanceWindow_basic (51.94s)
--- PASS: TestAccAWSSSMMaintenanceWindow_tags (120.54s)
--- PASS: TestAccAWSSSMMaintenanceWindow_disappears (38.53s)
--- PASS: TestAccAWSSSMMaintenanceWindow_multipleUpdates (78.33s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Cutoff (87.17s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Duration (84.84s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Enabled (88.86s)
--- PASS: TestAccAWSSSMMaintenanceWindow_EndDate (114.58s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Schedule (81.45s)
--- PASS: TestAccAWSSSMMaintenanceWindow_ScheduleTimezone (114.82s)
--- PASS: TestAccAWSSSMMaintenanceWindow_StartDate (113.39s)
...

@DrFaust92 DrFaust92 requested a review from a team December 14, 2019 13:44
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 14, 2019
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 14, 2019
refactor tags test + remove tags from basic test
refactor tests + add tags test
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 14, 2019
@DrFaust92 DrFaust92 changed the title [WIP]Refactor SSM resources to use keyvaluetags Refactor SSM resources to use keyvaluetags Dec 14, 2019
@bflad bflad self-assigned this Dec 17, 2019
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 17, 2019
@bflad bflad added this to the v2.43.0 milestone Dec 18, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSSSMActivation_basic (34.55s)
--- PASS: TestAccAWSSSMActivation_expirationDate (36.02s)
--- PASS: TestAccAWSSSMActivation_update (48.14s)

--- PASS: TestAccAWSSSMDocument_automation (36.26s)
--- PASS: TestAccAWSSSMDocument_basic (46.11s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (66.95s)
--- PASS: TestAccAWSSSMDocument_params (19.32s)
--- PASS: TestAccAWSSSMDocument_permission_batching (19.49s)
--- PASS: TestAccAWSSSMDocument_permission_change (73.30s)
--- PASS: TestAccAWSSSMDocument_permission_private (42.17s)
--- PASS: TestAccAWSSSMDocument_permission_public (30.52s)
--- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (48.34s)
--- PASS: TestAccAWSSSMDocument_session (25.64s)
--- PASS: TestAccAWSSSMDocument_Tags (65.48s)
--- PASS: TestAccAWSSSMDocument_update (32.67s)

--- PASS: TestAccAWSSSMMaintenanceWindow_basic (13.84s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Cutoff (31.15s)
--- PASS: TestAccAWSSSMMaintenanceWindow_disappears (12.43s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Duration (32.88s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Enabled (32.06s)
--- PASS: TestAccAWSSSMMaintenanceWindow_EndDate (40.70s)
--- PASS: TestAccAWSSSMMaintenanceWindow_multipleUpdates (26.45s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Schedule (34.80s)
--- PASS: TestAccAWSSSMMaintenanceWindow_ScheduleTimezone (42.91s)
--- PASS: TestAccAWSSSMMaintenanceWindow_StartDate (41.86s)
--- PASS: TestAccAWSSSMMaintenanceWindow_tags (40.01s)

--- PASS: TestAccAWSSSMMaintenanceWindowTarget_basic (16.03s)
--- PASS: TestAccAWSSSMMaintenanceWindowTarget_noNameOrDescription (15.03s)
--- PASS: TestAccAWSSSMMaintenanceWindowTarget_update (21.87s)
--- PASS: TestAccAWSSSMMaintenanceWindowTarget_validation (7.58s)

--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (24.99s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig (16.71s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters (24.40s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (45.00s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters (29.90s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (16.33s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskParameters (15.49s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (22.87s)

--- PASS: TestAccAWSSSMParameter_basic (21.89s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (32.04s)
--- PASS: TestAccAWSSSMParameter_disappears (17.83s)
--- PASS: TestAccAWSSSMParameter_fullPath (19.99s)
--- PASS: TestAccAWSSSMParameter_overwrite (32.00s)
--- PASS: TestAccAWSSSMParameter_secure (20.16s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (42.76s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (38.15s)
--- PASS: TestAccAWSSSMParameter_tags (37.14s)
--- PASS: TestAccAWSSSMParameter_Tier (41.45s)
--- PASS: TestAccAWSSSMParameter_updateDescription (32.29s)

--- PASS: TestAccAWSSSMPatchBaseline_basic (22.51s)
--- PASS: TestAccAWSSSMPatchBaseline_disappears (14.07s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (20.14s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (26.73s)

@bflad bflad merged commit 75f4cbf into hashicorp:master Dec 18, 2019
bflad added a commit that referenced this pull request Dec 18, 2019
@ghost
Copy link

ghost commented Dec 19, 2019

This has been released in version 2.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the ssm-tags-refactor branch December 24, 2019 17:09
@ghost
Copy link

ghost commented Jan 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ssm Issues and PRs that pertain to the ssm service. size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants