added extra arguments for explicit_auth_flows

[hunkeelin]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Related 10958

release notes for CHANGELOG

[bacoboy]

This appears to have stalled with the holiday. Any chance this can get some love soon? Thanks!

[rednap]

using a temporary work around with local-exec and aws cli (while we wait):

resource "null_resource" "add_SRP_to_cognito_app_client" {
    provisioner "local-exec" {
        command = "export AWS_DEFAULT_REGION=\"us-east-1\" && aws cognito-idp update-user-pool-client --user-pool-id ${aws_cognito_user_pool.cog_pool.id} --client-id ${aws_cognito_user_pool_client.cog_client.id} --explicit-auth-flows \"ALLOW_USER_SRP_AUTH\" \"ALLOW_REFRESH_TOKEN_AUTH\" \"ALLOW_CUSTOM_AUTH\""
    }   
    triggers = { 
        build_number = "${timestamp()}"
    }   
    depends_on = [aws_cognito_user_pool.cog_pool, aws_cognito_user_pool_client.cog_client]
}

every time you apply terraform will see you changed your auth_flows, update your user pool and client with the old style auth flows again, then your local exec runs and updates them to the new style auth flows. it's not pretty but it works.

[claydanford]

Any idea when this will be merged? Looks like the commas were resolved. This is blocking work, and I rather not use a custom provider or the cli work around.

Kindly,

CRD

[claydanford]

The fix that @rednap created does not work, as it will default all other custom options. For example, updating explicit_auth_flows via cli will clear out the support_identity_providers configuration.

[MatusiakMichal]

Same as @claydanford it indeed is a blocker. May we kindly get this merged already?

[bflad]

LGTM, thanks @hunkeelin 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCognitoUserPoolClient_allFields (9.45s)
--- PASS: TestAccAWSCognitoUserPoolClient_basic (10.04s)
--- PASS: TestAccAWSCognitoUserPoolClient_RefreshTokenValidity (14.31s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (14.72s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (15.06s)

[ghost]

This has been released in version 2.46.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!