Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut out Terraform rules into a ruleset plugin #1352

Closed
wata727 opened this issue Apr 13, 2022 · 0 comments · Fixed by #1496
Closed

Cut out Terraform rules into a ruleset plugin #1352

wata727 opened this issue Apr 13, 2022 · 0 comments · Fixed by #1496

Comments

@wata727
Copy link
Member

wata727 commented Apr 13, 2022

See also #1056

Terraform rules have been provided as built-in rules that are different from other rules for historical reasons.
https://github.com/terraform-linters/tflint/tree/642c99c08c282dd43ea10ebe5da16eb9f2a3252b/rules/terraformrules

By cutting them out as a ruleset plugin, like the AWS ruleset, I would like to reduce internal Terraform package dependencies. I believe that it will have a positive impact on users as it allows Terraform rules to be treated like any other ruleset.

Whether or not to make the Terraform ruleset a bundled plugin is worth considering. It's a good idea to first copy the existing rules to another repository and provide it as a bundled plugin. After that, I'm not sure if it's better to remove it and let a user install it explicitly, or leave the plugin bundled.

In designing the UX, ESLint's design will be helpful. ESLint has a config like "eslint:recommended", and it may be good to group the existing rules as well.
https://eslint.org/docs/rules/

This requires ongoing investigation, but I think there is still room for improvement in the first experience of TFLint. I would like to explore it in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant