From 2e98e3ae0ae6310f0dcc692d7fef9cec4ed124e7 Mon Sep 17 00:00:00 2001 From: Ben Drucker Date: Wed, 27 Jul 2022 16:14:42 -0700 Subject: [PATCH] add failing test for #1451 --- .../terraform_required_version_test.go | 35 +++++++++++++++---- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/rules/terraformrules/terraform_required_version_test.go b/rules/terraformrules/terraform_required_version_test.go index ee51242ac..129ae83e5 100644 --- a/rules/terraformrules/terraform_required_version_test.go +++ b/rules/terraformrules/terraform_required_version_test.go @@ -13,7 +13,7 @@ func Test_TerraformRequiredVersionRule(t *testing.T) { Expected tflint.Issues }{ { - Name: "no version", + Name: "unset", Content: ` terraform {} `, @@ -25,8 +25,25 @@ terraform {} }, }, { - Name: "version exists", + Name: "set", Content: ` +terraform { + required_version = "~> 0.12" +} +`, + Expected: tflint.Issues{}, + }, + { + Name: "multiple blocks", + Content: ` +terraform { + cloud { + workspaces { + name = "foo" + } + } +} + terraform { required_version = "~> 0.12" } @@ -38,12 +55,16 @@ terraform { rule := NewTerraformRequiredVersionRule() for _, tc := range cases { - runner := tflint.TestRunner(t, map[string]string{"module.tf": tc.Content}) + tc := tc - if err := rule.Check(runner); err != nil { - t.Fatalf("Unexpected error occurred: %s", err) - } + t.Run(tc.Name, func(t *testing.T) { + runner := tflint.TestRunner(t, map[string]string{"module.tf": tc.Content}) + + if err := rule.Check(runner); err != nil { + t.Fatal(err) + } - tflint.AssertIssues(t, tc.Expected, runner.Issues) + tflint.AssertIssues(t, tc.Expected, runner.Issues) + }) } }