Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COS module needs updates around monitoring and activity tracking for buckets #643

Closed
ocofaigh opened this issue Jun 14, 2024 · 0 comments
Closed
Assignees

Comments

@ocofaigh
Copy link
Member

Some changes are coming in IBM-Cloud/terraform-provider-ibm#5277 which will require some refactoring of the module...

Current code works like this:

  • When values are passed for activity_tracker_crn and sysdig_crn, this is what determines if activity tracking or monitoring should be enabled for buckets.

Refactoring considerations:

  • activity_tracker_crn and metrics_monitoring_crn are now becoming optional by the provider. If they are not specified, it will default to the default AT or Sysdig instances in the account. So with this in mind, we should probably create new variables enable_metrics_monitoring and enable_activity_tracking which default to true (see how upgrade test handles this).
  • management_events is also coming in new provider drop for AT, so that should be set to true as well.
  • take this opportunely to rename sysdig_crn to monitoring_crn

NB: modules/fscloud, modules/buckets, solutions/secure-cross-regional-bucket, solutions/secure-regional-bucket will all need updates based on the refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants