Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(budget): Only read project data when budget will be created #829

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

gleichda
Copy link
Contributor

When having a lot of projects the data resource makes the plan hard to read. To fix that only read the project data if it is needed.

@gleichda gleichda requested a review from a team as a code owner July 19, 2023 07:50
@gleichda gleichda changed the title Only read project data for budget when budget will be created feat(budget): Only read project data when budget will be created Jul 19, 2023
@bharathkkb
Copy link
Member

/gcbrun

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @gleichda. I think the lint is failing due to an unrelated issue, could you run make docker_generate_docs to sync them?

@bharathkkb
Copy link
Member

/gcbrun

@bharathkkb bharathkkb merged commit ee3865b into terraform-google-modules:master Jul 27, 2023
michalbagrowski pushed a commit to michalbagrowski/terraform-google-project-factory that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants