Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: test/setup/outputs.folder_id returns folder_id #712

Merged
merged 1 commit into from
Apr 20, 2022
Merged

fix!: test/setup/outputs.folder_id returns folder_id #712

merged 1 commit into from
Apr 20, 2022

Conversation

apeabody
Copy link
Contributor

fix!: test/setup/outputs.folder_id returns folder_id instead of folders/{folder_id}

Closes #711

@comment-bot-dev
Copy link

@apeabody
Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody marked this pull request as ready for review April 20, 2022 17:49
@apeabody apeabody requested a review from a team as a code owner April 20, 2022 17:49
@morgante
Copy link
Contributor

@apeabody This shouldn't be a breaking change, since it only impacts the tests.

@morgante morgante merged commit 8f72474 into terraform-google-modules:master Apr 20, 2022
@apeabody apeabody deleted the fix-patch-10 branch April 20, 2022 18:34
@apeabody
Copy link
Contributor Author

apeabody commented Apr 20, 2022

@apeabody This shouldn't be a breaking change, since it only impacts the tests.

👍 I was being careful as it changed one of the examples, but yes the main module/sub-modules are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test/setup/outputs.folder_id returns folders/{folder_id} instead of folder_id
3 participants