Wrap budget_name output with length check #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `terraform plan -refresh-only` and `var.create_budget` turns from `false` to `true` (via passing a non-null `budget_amount` in [`create_budget = var.budget_amount != null`](https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/main.tf#L90) this fails with the message: ``` │ Error: Invalid index │ │ on .terraform/modules/project.project-factory/modules/budget/outputs.tf line 19, in output "name": │ 19: value = var.create_budget ? google_billing_budget.budget[0].name : "" │ ├──────────────── │ │ google_billing_budget.budget is empty tuple │ │ The given key does not identify an element in this collection value: the │ collection has no elements. ``` Seems related to hashicorp/terraform#23222 Run on: Terraform v1.0.11 on darwin_amd64
jpedro
changed the title
|
Thanks for the PR! 🚀 |
|
I signed the CLA. So please run a re-scan. |
morgante
approved these changes
Jan 5, 2022
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
terraform plan -refresh-onlyandvar.create_budgetturns fromfalsetotrue(via passing a non-nullbudget_amountincreate_budget = var.budget_amount != nullthis fails with the message:Seems related to hashicorp/terraform#23222
Run on: Terraform v1.0.11 on darwin_amd64