Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required_providers after change in b6d7bf1 #631

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Update required_providers after change in b6d7bf1 #631

merged 1 commit into from
Oct 20, 2021

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Oct 20, 2021

#626 should have included an update to the required_providers. Without this, a terraform root module that makes use of this module will not know that it needs to download the GA google provider during terraform init.

Additionally, #626 broke the ability to successfully pass a provider because they no longer match the correct type. For example, this in 11.2.1

  providers = {
    google-beta = google-beta.budget
  }

will not continue to work even if you modify it to something like

  providers = {
    google = google-beta.budget
  }

because the correct type of provider (google) is not being passed. The Billing Budget API prohibits end user credentials for authentication for a number of actions so this ability is somewhat important in the module.

@tpdownes tpdownes requested a review from a team as a code owner October 20, 2021 19:51
@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante morgante merged commit de67066 into terraform-google-modules:master Oct 20, 2021
@tpdownes
Copy link
Member Author

Thanks. Sorry for the inadvertent mistake in #626. Learned something!

@tpdownes tpdownes deleted the promote_ga branch October 20, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants