-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow explicit Provider configuration in Module #624
fix: Allow explicit Provider configuration in Module #624
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for the PR! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to gsuite_enabled as well.
@morgante good catch! Thank you, fixed. Re: the Actions, I am seeing one failing but I do not have permission to view the Google Cloud Build project: is there something I need to action for this to pass, or is it expected to fail when triggered by a non-collaborator?
Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing now, thanks!
Closes #623
This change will enable explicit provider configuration, e.g:
I chose the version constraints (
>= 3.50, < 4.0
) because that is the minimum required to meet every nested module's requirements.modules/shared_vpc_access
requires>= 3.43, <4.0
but3.43
would not meet the>= 3.50, < 4.0
requirements ofmodules/core_project_factory
.I ran some checks and it's already not possible to use any part of this project with a version less than
3.50
because there's already an implicit dependency on>= 3.50
-- this change just makes it explicit, everything makes use of something with a dependency of>= 3.50
(includinggsuite_group
). Therefore, I do not believe this is a breaking change.I reviewed the nested modules
required_providers
while I was doing this. Every one has arequired_providers
exceptsvpc_service_project
so I have added that to this PR so any provider configuration is passed through.