added time_sleep and dependancies on shared vpc attachment

[rm-paoloventriglia]

This fixes #607

Service project needs to be added to the VPC-SC perimeter before it get attached to the SharedVPC (that is part of the same VPC-SC Perimeter) else you get a Error 403: Request is prohibited by organization's policy. vpcServiceControlsUniqueIdentifier

Adding google_access_context_manager_service_perimeter_resource.service_perimeter_attachment[0] to depends_on for "google_compute_shared_vpc_service_project" "shared_vpc_attachment" doesn't work either as the VPC-SC api seems to be eventually consistent.

Adding a 5s time_sleep although not ideal fixes the issue.

[comment-bot-dev]

Thanks for the PR! 🚀
✅ Lint checks have passed.

[bharathkkb]

Thanks for the PR @paolo-rm

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[rm-paoloventriglia]

@googlebot I signed it!

[morgante]

@paolo-rm Please make sure you sign the CLA with these emails:

• [email protected]
• [email protected]

[rm-paoloventriglia]

@morgante I have signed it with [email protected] and added that address to github and verified it plus added it to git commits for this repo. Is that ok? My company has two emails and only have a Google account with [email protected]. Sorry haven't contribute before, I was a bit confused. Is this ok now?

[morgante]

@paolo-rm Yep, it's working now!