feat: add support for uniform_bucket_level_access #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
morgante
reviewed
May 27, 2021
There was a problem hiding this comment.
@bharathkkb This seems like a best practice. Should we just make it the default?
|
@morgante yeah we should make it a default. |
|
@bharathkkb and @morgante can we merge this if everything is as expected? |
morgante
approved these changes
Jun 3, 2021
Closed
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #586
Adding a variable to enable uniform-bucket-level access on the project bucket if users wish to.
Default is kept false so no change to integration tests, the module remains the same in the default config
This is considered a policy violation by terrascan on accurics.gcp.IAM.122
P.S I know we can turn off the bucket creation but I would rather not do the same every time I want to make a project with this module