Simplify project_id output in core_project_factory #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into a case where somehow `google_compute_shared_vpc_service_project.shared_vpc_attachment` was an "empty tuple" in the state, and this output was failing because it was trying to index into it. I came across hashicorp/terraform#25578, which might be related, but it does still happen with the latest version of Terraform as of opening this bug (v0.14.9). Regardless, it seems to me that all this is doing is building a list then taking the first element, so the one-liner should be equivalent.
|
Thanks for the PR! 🚀 |
bharathkkb
reviewed
Apr 5, 2021
There was a problem hiding this comment.
IIRC when building the list it will resolve all elements and then take the first element so we are able to wait on svpc which was added in #432. I don't think we should remove the wait on svpc, perhaps we can use try to catch the null error?
morgante
suggested changes
Apr 5, 2021
morgante
approved these changes
Apr 5, 2021
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a case where somehow
google_compute_shared_vpc_service_project.shared_vpc_attachmentwas an "empty tuple" in the state, and this output was failing because it was trying to index into it. I came across hashicorp/terraform#25578, which might be related, but it does still happen with the latest version of Terraform as of opening this bug (v0.14.9).Regardless, it seems to me that all this is doing is building a list then taking the first element, so the one-liner should be equivalent and avoids this error.