fix: Composer shared vpc #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
morgante
approved these changes
Mar 24, 2021
gorge511
added a commit
to gorge511/terraform-google-project-factory
that referenced
this pull request
Jun 14, 2022
These comments were removed in terraform-google-modules#567 and the code was confusing without them.
gorge511
added a commit
to gorge511/terraform-google-project-factory
that referenced
this pull request
Jun 14, 2022
These comments were removed in terraform-google-modules#567 and the code was confusing without them.
gorge511
added a commit
to gorge511/terraform-google-project-factory
that referenced
this pull request
Jun 14, 2022
These comments were removed in terraform-google-modules#567 and the code was confusing without them.
bharathkkb
pushed a commit
that referenced
this pull request
Jul 28, 2022
These comments were removed in #567 and the code was confusing without them. Co-authored-by: Jirka Korejtko <[email protected]>
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer needs role composer.sharedVpcAgent or networkAdmin at the project level because of peering. Therefore, this hotfix separetes the role in another resource in the same way that we are implementing it in the gke agent.