-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shared_vpc resources at folder level is in beta #560
Conversation
Thanks for the PR! 🚀 |
@xingao267 Does this actually require the beta API? The fields seem to be the same. |
yea, we recently encountered this error (the service account that tries to enable shared VPC host and service project in a folder gets a 403 permission denied error even it has the folder level Shared VPC Admin role), and after looking into this, the doc says if you have Shared VPC Admin role at the folder level, you need to use I'm not sure why it was fine before, as I assume there are tests that cover folder level shared VPCs, but the issues seems just surfaced recently. |
/gcbrun |
Google provider (not beta) before 3.60 actually used beta calls for shared vpc. It was "fixed" in hashicorp/terraform-provider-google@a6f342c#diff-d00da7be384ad2ae0338a4ab6a736a8635ca9d9a9265fc14e6a792865b9214fa |
Thanks for finding the root cause! |
ref: