-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 10.0.0 #496
Conversation
Testing both the current master and branch v10.0.0 I find that using
I think you need to set |
@downwithwindoze thanks for the report. Tracking here: #497 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking issues:
- Restore default_service_account = "keep" for 10.0 #497
- Feature: Adds new restore_policy on google_project_default_service_accounts hashicorp/terraform-provider-google#7768
- New provider release with Feature: Adds new restore_policy on google_project_default_service_accounts hashicorp/terraform-provider-google#7768
- Switch to
REVERT_AND_IGNORE_FAILURE
and pin minimum provider version to v3.50.0 - Rename shared_vpc #463
- Upgrade guide
e18be17
to
158bf9f
Compare
158bf9f
to
f6587e1
Compare
@morgante PR 7768 is merged. Do you think we can get this release until tomorrow? I'm going to talk about this module and I'd like to show the version without gcloud if possible 😄 |
@thiagonache Since we will need to set a version constraint I'm going to hold off on release until we can do that. Can you simply point to master for your talk though? |
I could but I'll enforce that we should use immutable infrastructure by setting tags, etc. and that would "violate" what I'm talking about.... but I can handle that in another manner. I just thought that I can use my own github or use the latest version on the demo and just show the code changes of the new version |
5e435f6
to
e5504e6
Compare
@thiagonache Could you switch to REVERT_AND_IGNORE_FAILURE and pin minimum provider version to v3.50.0? |
I've been busy. It took me a while to be able to spare some time. There it is #511 |
@morgante Were you thinking of dropping support for 0.12 with this or next major? |
@bharathkkb We can do it now. |
e5504e6
to
365ee67
Compare
c70ee94
to
2e08f96
Compare
The last item on the check list "Switch to REVERT_AND_IGNORE_FAILURE and pin minimum provider version to v3.50.0" seems done in #511. Any chance we can release this major soon? |
Sent #516 to fix the lint issue here. |
we should also do this #463 for clarity |
Is it being worked on? We kind of need the next version of Project Factory to be released soon to use the activate API identities feature in shared_vpc module and also Terraform 0.13 support. |
I can work on it in the next days or if you want to take it, it's okay |
I'm not familiar with the context and discussions behind this issue. Will leave this to you @thiagonache. Thanks! |
@thiagonache mind if I take this? My team is currently blocked until 10.0.0 is released so I can get this change in today |
not at all... go ahead!
…On Mon, Dec 14, 2020 at 5:02 PM Anshu Rao ***@***.***> wrote:
I can work on it in the next days or if you want to take it, it's okay
@thiagonache <https://github.com/thiagonache> mind if I take this? My
team is currently blocked until 10.0.0 is released so I can get this change
in today
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#496 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATHKBP4LYK3HPBCFFW2RV3SUZVMFANCNFSM4TQIQAWA>
.
--
[]s
Thiago Nache
|
d27c133
to
c948727
Compare
@thiagonache @bharathkkb @ChandranshuRao14 Does anyone have bandwidth to write an upgrade guide? |
@thiagonache has written the initial version, will work with @ChandranshuRao14 to include changes from the rename |
c948727
to
18c28a3
Compare
* chore: release 10.0.0 * Update CHANGELOG.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Morgante Pell <[email protected]>
🤖 I have created a release *beep* *boop*
10.0.0 (2020-12-16)
⚠ BREAKING CHANGES
Features
Bug Fixes
svpc_service_project
(#517) (86819d7)This PR was generated with Release Please.