Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add billingbudgets.googleapis.com to precondition script. #493

Merged
merged 1 commit into from
Nov 5, 2020
Merged

fix: Add billingbudgets.googleapis.com to precondition script. #493

merged 1 commit into from
Nov 5, 2020

Conversation

morgante
Copy link
Contributor

@morgante morgante commented Nov 5, 2020

Fixes #486.

@morgante morgante requested a review from a team as a code owner November 5, 2020 16:33
@thiagonache
Copy link
Contributor

should we also add check in the preconditions script?

@morgante
Copy link
Contributor Author

morgante commented Nov 5, 2020

@thiagonache No I don't think a check is necessary. The error from this is fairly clear and recoverable.

@bharathkkb
Copy link
Member

/gcbrun

bharathkkb
bharathkkb approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
CI failure seems unrelated

@morgante morgante merged commit f9b53c3 into master Nov 5, 2020
@morgante morgante deleted the morgante-patch-2 branch November 5, 2020 17:46
This was referenced Aug 18, 2022
Closed
Closed
@release-please release-please bot mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seed project script misses dependency of billing budget feature
3 participants
@morgante @thiagonache @bharathkkb