Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes preconditions.py script into the module #478

Merged
merged 10 commits into from
Oct 14, 2020
Merged

Removes preconditions.py script into the module #478

merged 10 commits into from
Oct 14, 2020

Conversation

thiagonache
Copy link
Contributor

This PR removes the null_resource for preconditions.py script as per the issue #407

@thiagonache thiagonache requested a review from a team as a code owner October 14, 2020 20:48
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

test/scripts/preconditions/test_preconditions.py Outdated Show resolved Hide resolved
docs/running_preconditions_script.md Outdated Show resolved Hide resolved
@thiagonache thiagonache requested a review from morgante October 14, 2020 21:45
@thiagonache
Copy link
Contributor Author

Thanks for working on this!

Sorry for the delay. I've been busy. I wanted to do this past week.

@morgante morgante merged commit 79f7c95 into terraform-google-modules:master Oct 14, 2020
@iestarks
Copy link

Sorry if this is not the right area to raise this question, but I have been trying to run this and even using the setup script, I am still experiencing this issue and not sure what IAM member and role to adjust to get past this error.

Any ideas?

Error: failed pre-requisites: missing permission on "billingAccounts/012C34-27AF51-73A832": billing.resourceAssociations.create

@morgante
Copy link
Contributor

@iestarks You need to make sure your service account (or user identity) has Billing User on the Billing Account - https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/docs/TROUBLESHOOTING.md#missing-rolesbillinguser-role

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants