Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with empty subnet defaults and Shared VPC #382

Merged
merged 4 commits into from
Feb 23, 2020
Merged

Fix issue with empty subnet defaults and Shared VPC #382

merged 4 commits into from
Feb 23, 2020

Conversation

morgante
Copy link
Contributor

Fixes #378 and adds a test case to prevent regressions.

@morgante morgante requested a review from rjerrems February 21, 2020 23:56
rjerrems
rjerrems approved these changes Feb 23, 2020
View reviewed changes
Copy link
Contributor

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@morgante morgante merged commit d31e068 into master Feb 23, 2020
@morgante morgante mentioned this pull request Feb 25, 2020
Merged
@morgante morgante deleted the fix/empty-subnets branch August 13, 2020 15:11
This was referenced Aug 18, 2022
Closed
Closed
@release-please release-please bot mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjerrems rjerrems rjerrems approved these changes

@adrienthebo adrienthebo Awaiting requested review from adrienthebo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v7.0.1 breaks shared VPC setup w/o explicit subnets
2 participants
@morgante @rjerrems