Bump provider versions #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. What is the intent with this change? We try not to be overly strict with provider versions if we don't have to, so I'm not sure we need to restrict the provider versions further if we're not depending on a new feature. |
|
The main reason is the change in modules/fabric-project/versions.tf - that one is needed to be able to use a 3.x.y provider version. Otherwise terraform will complain it could not find a valid version. |
|
Got it, thanks. In that case, could we reduce this change to update the examples + that file, while backing out the changes to other module versions? |
wmuizelaar
force-pushed
the
bump_provider_versions
branch
2 times, most recently
from
d74f0f2 to
749bbd2
Compare
|
Sure! Hope to have applied your desired changes with this latest version. |
wmuizelaar
force-pushed
the
bump_provider_versions
branch
from
749bbd2 to
eb99994
Compare
morgante
approved these changes
Feb 3, 2020
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the core_project_factory that still pointed to 2.x