Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What happened with the disable_services_on_destroy variable? #124

Closed
amardomingo opened this issue Jan 21, 2019 · 2 comments · Fixed by #125
Closed

What happened with the disable_services_on_destroy variable? #124

amardomingo opened this issue Jan 21, 2019 · 2 comments · Fixed by #125

Comments

@amardomingo
Copy link

The variable disable_services_on_destroy use to be added to the core module call in the /main.tf file. However, at some point it seems it was removed (commit 3738754 )

Is this intended? If so, it is possible to regain that funcionality somehow?
@aaron-lane
Copy link
Contributor

Hi @amardomingo.

Thank you for catching this issue. It is not intended and will be rectified.

@aaron-lane aaron-lane mentioned this issue Jan 21, 2019
Merged
@amardomingo
Copy link
Author

Great! Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing disable_services_on_destroy terraform-google-modules/terraform-google-project-factory
2 participants
@amardomingo @aaron-lane