Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add sensitive true flag to output auth_string #93

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix: add sensitive true flag to output auth_string #93

merged 1 commit into from
Jul 20, 2022

Conversation

jfmrm
Copy link
Contributor

@jfmrm jfmrm commented Jul 19, 2022 •
edited
Loading

Fix: add sensitive flag on the auth_string output so it stops breaking applies on tf 1+

Solves issue #86

@comment-bot-dev
Copy link

@jfmrm
Thanks for the PR! 🚀
✅ Lint checks have passed.

bharathkkb
bharathkkb approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jfmrm

@bharathkkb bharathkkb merged commit 20b4c61 into terraform-google-modules:master Jul 20, 2022
@release-please release-please bot mentioned this pull request Jul 20, 2022
Merged
@jfmrm jfmrm deleted the fix/sensitive-output branch July 20, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfmrm @comment-bot-dev @bharathkkb