Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows setting a description for the maintenance policy #272

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

azen1k5
Copy link
Contributor

@azen1k5 azen1k5 commented Jan 17, 2025

This pull requests solves my issues #271 and allows the setting of a custom description for the maintenance policy.

@azen1k5 azen1k5 requested review from imrannayer, q2w and a team as code owners January 17, 2025 19:06
Copy link

google-cla bot commented Jan 17, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@azen1k5 azen1k5 changed the title allows setting a description for the maintenance policy feat: allows setting a description for the maintenance policy Jan 17, 2025
@imrannayer imrannayer self-assigned this Jan 23, 2025
@imrannayer
Copy link
Collaborator

@azen1k5 can u plz follow this doc to fix lint issues.

@azen1k5
Copy link
Contributor Author

azen1k5 commented Jan 23, 2025

@imrannayer sorry I thought I checked before. I fixed the linting issue.

@imrannayer
Copy link
Collaborator

/gcbrun

@azen1k5
Copy link
Contributor Author

azen1k5 commented Jan 24, 2025

@imrannayer sorry just saw that I missed the docs. Updated it.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit e2519d4 into terraform-google-modules:main Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants