Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing input: connect_mode #18

Merged
merged 5 commits into from
Jun 2, 2020

Conversation

Santos92
Copy link
Contributor

@Santos92 Santos92 commented Apr 16, 2020

Fixes #17

@morgante
Copy link
Contributor

Looks like it's only available in newer provider versions. Could you add a provider version constraint in the versions.tf file?

@morgante
Copy link
Contributor

Looks like the version also needs to be upgraded here.

@Santos92
Copy link
Contributor Author

Santos92 commented Jun 2, 2020

Hey @morgante is there anything that is required of me or is this ready to be merged ? thank you for the help!

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@morgante morgante merged commit d3c44dd into terraform-google-modules:master Jun 2, 2020
@sclausson
Copy link

@morgante thanks for merging this. Is it possible to release a new version of the module to include this change?

@morgante
Copy link
Contributor

@sclausson Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing input: connect_mode
3 participants