Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow overriding download behavior using GCLOUD_TF_DOWNLOAD environment variable. #59

Merged
merged 8 commits into from
Jul 19, 2020
Merged

feat: Allow overriding download behavior using GCLOUD_TF_DOWNLOAD environment variable. #59

merged 8 commits into from
Jul 19, 2020

Conversation

morgante
Copy link
Contributor

This should make customizing the behavior easier without plumbing through Terraform modules everywhere.

@comment-bot-dev
Copy link

comment-bot-dev commented Jul 17, 2020 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante morgante requested a review from bharathkkb July 17, 2020 20:09
bharathkkb
bharathkkb approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just a question about the implementation

main.tf Show resolved Hide resolved
@morgante morgante merged commit 9041027 into master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morgante @comment-bot-dev @bharathkkb