fix: Secrets when project_id is known after apply

[deas]

Current code fails for me when the project hosting the function is created in the same execution:

│ Error: Invalid for_each argument
│ 
│   on .terraform/modules/instance_actions.main/main.tf line 93, in data "google_project" "nums":
│   93:   for_each   = toset(concat(compact([for item in var.secret_environment_variables : lookup(item, "project_id", "")]), [var.project_id]))

The attached patch fixes this for me.

Please see hashicorp/terraform#28925 for a more detailed description of the general problem.

[bharathkkb]

Thanks for the PR @deas

[bharathkkb]

Can we only create this if any secrets exist?

count = length(var.secret_environment_variables) > 0 ? 1 : 0

[deas]

I think not, because doing just that would break:

try(data.google_project.nums[secret_environment_variables.value["project_id"]].number, data.google_project.default.number)

[bharathkkb]

Not sure I follow can't we just do

try(data.google_project.nums[secret_environment_variables.value["project_id"]].number, data.google_project.default[0].number)

IIUC we use this just for secrets and length of secret_environment_variables should be known at apply time even if values are not?

[deas]

Sorry, missed that. Updated the PR.

[comment-bot-dev]

@deas
Thanks for the PR! 🚀
✅ Lint checks have passed.