Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for setting build environment variables #89

Conversation

grumpydude
Copy link
Contributor

This adds the capability to pass build time environment variables such as GOOGLE_FUNCTION_SOURCE.

@grumpydude grumpydude requested a review from morgante as a code owner March 25, 2022 06:19
@google-cla
Copy link

google-cla bot commented Mar 25, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@grumpydude grumpydude force-pushed the build-environment-variables branch 2 times, most recently from 206c5db to 5c04b68 Compare March 25, 2022 09:55
@matty-rose
Copy link

hey @morgante is it possible to tell what the CI failure is?

@morgante
Copy link
Contributor

        	            	FatalError{Underlying: error while running command: exit status 1; ╷
        	            	│ Error: Error waiting for Creating CloudFunctions Function: Error code 13, message: The service has encountered an internal error. Please try again later
        	            	│ 
        	            	│   with module.localhost_function.google_cloudfunctions_function.main,
        	            	│   on ../../main.tf line 90, in resource "google_cloudfunctions_function" "main":
        	            	│   90: resource "google_cloudfunctions_function" "main" {
        	            	│ 
        	            	╵}
        	            	

I'm retriggering the execution.

@bharathkkb
Copy link
Member

@morgante I have a fix in 9dea6c8 for build failures. Default SA was disabled which caused CF to fail with a non intuitive error b/227216425

morgante
morgante previously approved these changes Mar 31, 2022
@matty-rose
Copy link

Hi @morgante @bharathkkb is this PR able to be merged if the CI failure is unrelated?

@bharathkkb
Copy link
Member

Hi @matty-rose Could you rebase this PR?

@grumpydude
Copy link
Contributor Author

@morgante I've rebased.

@grumpydude grumpydude requested a review from morgante April 21, 2022 07:04
@comment-bot-dev
Copy link

@grumpydude
Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grumpydude

@bharathkkb bharathkkb merged commit 022440d into terraform-google-modules:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants