-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for setting build environment variables #89
feat: add support for setting build environment variables #89
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
206c5db
to
5c04b68
Compare
hey @morgante is it possible to tell what the CI failure is? |
I'm retriggering the execution. |
Hi @morgante @bharathkkb is this PR able to be merged if the CI failure is unrelated? |
Hi @matty-rose Could you rebase this PR? |
5c04b68
to
b6fc9bc
Compare
@morgante I've rebased. |
@grumpydude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @grumpydude
This adds the capability to pass build time environment variables such as GOOGLE_FUNCTION_SOURCE.