-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change to allow create variable within specific vpc objects #773
feat: Change to allow create variable within specific vpc objects #773
Conversation
…both all vpc endpoints but also specific vpc endpoints, whereas currently we can only disable and enable all or nothing.
Looks good. Could you please update the code in In this block, for example: terraform-aws-vpc/examples/complete-vpc/main.tf Lines 123 to 127 in e021186
|
Awesome I have added it in the complete vpc |
## [3.14.0](v3.13.0...v3.14.0) (2022-03-31) ### Features * Change to allow create variable within specific vpc objects ([#773](#773)) ([5913d7e](5913d7e))
This PR is included in version 3.14.0 🎉 |
Thank you @matipadeveloper for this PR! |
Anytime @antonbabenko thank you for the module! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This change is to allow for create to work within each vpc endpoint object. If the create is outside of a vpc endpoint then that will take priorty over the specific vpc endpoints create.
Motivation and Context
This will make the script alot more flexible and fine grain. As you can go down to object level to specify which objects should be created or not. Making a lot more use cases possible.
Breaking Changes
The only thing that was introduced that would be debtable is try but it seems try has been there for a long time so seem like it is backwards compatible.
How Has This Been Tested?
Yes I have an example project which I tested this on. I tested with multiple use cases to make sure.
This change will also default create to true with object level vpc endpoints just like it has been. Meaning create is still optional for object level and resource level create.