feat: Add variable create_lambda_permission in notification module #302
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrabin
changed the title
antonbabenko
requested changes
Jan 13, 2025
antonbabenko
changed the title
|
This doesn't seem like a breaking change, since |
I realized you're right! |
I renamed it to |
maxrabin
changed the title
antonbabenko
changed the title
antonbabenko
approved these changes
Jan 13, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Jan 13, 2025
## [4.4.0](v4.3.0...v4.4.0) (2025-01-13) ### Features * Add variable create_lambda_permission in notification module ([#302](#302)) ([5b71671](5b71671))
|
This PR is included in version 4.4.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the Notification module create a new variable a new
create_lambda_policythat functions similar tocreate_sqs_policyandcreate_sns_policyMotivation and Context
I define and manage my Lambda Policy separate from the Terraform where I manage my S3 Notifications. I don't want this module to force me to manage the Lambda policy here.
Fixes #301
Breaking Changes
I think that migrating
aws_lambda_permission.allowfrom a single to acountthis will cause the Resource to be recreated.This can be avoided by performing
terraform state mvThere are 3 types of notifications, and this change brings Lambda in line with SQS and SNS that support
create_sqs_policyandcreate_sns_policyHow Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request