Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added interpreter variable to control script runtime #92

Merged
merged 4 commits into from
Mar 1, 2021

Conversation

zandabanda
Copy link
Contributor

@zandabanda zandabanda commented Jan 5, 2021

Description

Include interpreter argument of provisioner.local_exec block as variable in null_resource.deploy. Allow user to control the execution runtime of the deploy script.

Motivation and Context

/bin/bash isn't necessarily guaranteed to be the selected shell, leading to failures in bash built-in control flow.
See issue <>

Breaking Changes

How Has This Been Tested?

@antonbabenko antonbabenko marked this pull request as ready for review March 1, 2021 13:27
@antonbabenko
Copy link
Member

Fixes #118

@antonbabenko antonbabenko merged commit 6b10064 into terraform-aws-modules:master Mar 1, 2021
@antonbabenko
Copy link
Member

Thanks @zandabanda for this fix!

v1.41.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants