Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use AWSXRayDaemonWriteAccess instead of deprecated AWSXrayWriteOnlyAccess #211

Merged

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Oct 7, 2021

Description

Resolves #208

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@antonbabenko antonbabenko changed the title Use AWSXRayDaemonWriteAccess instead of deprecated AWSXrayWriteOnlyAccess fix: Use AWSXRayDaemonWriteAccess instead of deprecated AWSXrayWriteOnlyAccess Oct 7, 2021
@antonbabenko antonbabenko merged commit 3d52044 into terraform-aws-modules:master Oct 7, 2021
@antonbabenko
Copy link
Member

Thank you!

v2.21.0 has been just released.

@pdecat pdecat deleted the update_xray_iam_policy branch October 7, 2021 07:58
@pdecat
Copy link
Contributor Author

pdecat commented Oct 7, 2021

@antonbabenko You're too quick 🚀 I was looking into which semantic category to put this in 😄

@antonbabenko
Copy link
Member

:) I normally pick between:

  1. feat - something new
  2. fix - something existing but fixing
  3. docs - new meaningful content in docs
  4. chore - something not relevant for the end-users (eg CI, spelling fixes, sometimes examples)
  5. BREAKING CHANGE - well, it will be a major release because it requires some attention for the users.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use AWSXRayDaemonWriteAccess instead of deprecated AWSXrayWriteOnlyAccess
2 participants