feat: Reliable passing build plan by a separate file + minor changes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idn't used working_dir for all calls
If the `docker_pip_cache = true` then "${artifacts_dir}/cache/pip" is used
for storing downloaded pip packages.
WARNING: Because pip runs inside of docker it runs with a uid=0 and gid=0
permissions, so files in the "${artifacts_dir}/cache/pip" directory will have
a root user permissions. To remove the "${artifacts_dir}" directory entirely
a sudo prefixed command is required, like: `sudo rm ${artifacts_dir} -r`.
It is also possible to speicify another location for the pip cache
directory by setting the docker_pip_cache variable to a string,
like: `docker_pip_cache = "/tmp/pip_cache"`
To be independant from lambci docker images do chown just current working directory because there is no directory changes and all packages installation just happens to cwd.
So a local_file resource will be only a safe measure in case of a situation like: 1. Store a terraform plan to a file. 2. Remove all zip and plan files from artifacts dir. 3. Run `teraform apply` from the stored plan file.
…name
Hints:
* When there is a goal to don't have deferred data sources
which will be read on the Terraform's apply phase. And also
design a module that wouldn't unexpectedly start to produce
such read deferals, it is needed to:
* Separate all possible variables that may be defined by the end user
into two sets whether it makes sense to define its content as a result
of some resource or not. And haven't use any of such variables that
may have a value derived from resources as an input values of any
data sources introduced by the module.
* Another approach is to explicitly claim for the end user that
some scope of variables should be statically defined and can't
use any interpolations or assignments that include values from any
resource results. And let to know what to expect if someone want to
don't obey for such restrictions.
antonbabenko
reviewed
Jun 9, 2020
It seems that lambda.py is a confusable name and we have the package.tf file so it's better to name the helper as package.py to make it associated as a companion script for the package.tf file.
antonbabenko
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Jun 9, 2020
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also in an archive_plan resource the build plan data are seen.
It seems that lambda.py is a confusable name and we have the
package.tf file so it's better to name the helper as package.py
to make it associated as a companion script for the package.tf file.